Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor middleware processing (v2) #440

Merged
merged 10 commits into from
Mar 27, 2020
Merged

Refactor middleware processing (v2) #440

merged 10 commits into from
Mar 27, 2020

Commits on Mar 25, 2020

  1. add alternative implementation of middleware processing 

    the main difference is this implementation aggregates errors from
multiple failed listener middleware chains into a single error
which captures all of them.

the previous implementation is mostly commented out.

lint is passing, tests are failing.
    @aoberoi
    aoberoi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    ab5591b View commit details
    Browse the repository at this point in the history

  2. Merge branch '@slack/bolt@next' into v2-refactor-middleware-processing

    @aoberoi
    aoberoi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    12bbf7e View commit details
    Browse the repository at this point in the history

  3. removes dead code and moves the new processMiddleware back to the 

    file where the old one was.
    @aoberoi
    aoberoi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3fc9ba3 View commit details
    Browse the repository at this point in the history

  4. it turns out context isn't necessary since its always available 

    through scope closure. might as well remove to keep things tidy.
    @aoberoi
    aoberoi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    5d39aea View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Adds tests for multiple listener error behavior, fixes bugs

    @aoberoi
    aoberoi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    9a74f9e View commit details
    Browse the repository at this point in the history

  2. Merge branch '@slack/bolt@next' into v2-refactor-middleware-processing

    @aoberoi
    aoberoi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    572d8e8 View commit details
    Browse the repository at this point in the history

  3. fix errors in integration tests

    @aoberoi
    aoberoi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    13cbd88 View commit details
    Browse the repository at this point in the history

  4. increase test coverage, fix bug with single listener errors

    @aoberoi
    aoberoi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    b7b7607 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. take a penny, leave a penny: moar coverage

    @aoberoi
    aoberoi committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a39828f View commit details
    Browse the repository at this point in the history

  2. Merge branch '@slack/bolt@next' into v2-refactor-middleware-processing

    @aoberoi
    aoberoi committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    edfcfbc View commit details
    Browse the repository at this point in the history