Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added migration guide for Bolt@2.x #442

Merged
merged 2 commits into from
Mar 26, 2020
Merged

added migration guide for Bolt@2.x #442

merged 2 commits into from
Mar 26, 2020

Conversation

stevengill
Copy link
Member

Summary

Added Migration guide for Bolt@2.x. Also made some small changes on other docs pages.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #442 into @slack/bolt@next will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           @slack/bolt@next     #442   +/-   ##
=================================================
  Coverage             85.71%   85.71%           
=================================================
  Files                     7        7           
  Lines                   532      532           
  Branches                156      156           
=================================================
  Hits                    456      456           
  Misses                   48       48           
  Partials                 28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d23d1...f9c07d9. Read the comment docs.

@seratch seratch requested review from aoberoi and shaydewael and removed request for aoberoi March 26, 2020 00:54
seratch
seratch reviewed Mar 26, 2020
View reviewed changes
docs/_tutorials/migration_v2.md Outdated Show resolved Hide resolved
docs/_tutorials/migration_v2.md Outdated Show resolved Hide resolved
docs/_tutorials/migration_v2.md Show resolved Hide resolved
seratch added a commit to seratch/bolt-js that referenced this pull request Mar 26, 2020
@seratch
Add Japanese version to PR slackapi#442
6395c38
@seratch seratch mentioned this pull request Mar 26, 2020
Merged
2 tasks
@seratch seratch added docs M-T: Documentation work only semver:major labels Mar 26, 2020
@seratch seratch added this to the V2 milestone Mar 26, 2020
aoberoi
aoberoi suggested changes Mar 26, 2020
View reviewed changes
docs/_advanced/error_handling.md Outdated Show resolved Hide resolved
docs/_advanced/error_handling.md Outdated Show resolved Hide resolved
docs/_advanced/middleware_global.md Outdated Show resolved Hide resolved
docs/_advanced/middleware_listener.md Outdated Show resolved Hide resolved
docs/_basic/listening_actions.md Outdated Show resolved Hide resolved
docs/_tutorials/migration_v2.md Outdated Show resolved Hide resolved
docs/_tutorials/migration_v2.md Outdated Show resolved Hide resolved
docs/_tutorials/migration_v2.md Outdated Show resolved Hide resolved
seratch added a commit to seratch/bolt-js that referenced this pull request Mar 26, 2020
@seratch
Apply the changes corresponding to the suggestions slackapi#442
2e8d09d
@seratch
Copy link
Member

seratch commented Mar 26, 2020

Applied all the suggestions by @aoberoi to the Japanese version by 2e8d09d

@stevengill @aoberoi
Apply suggestions from code review
f9c07d9 
Co-Authored-By: Ankur Oberoi <aoberoi@gmail.com>
@stevengill stevengill merged commit 9a3fd0b into slackapi:@slack/bolt@next Mar 26, 2020
seratch added a commit that referenced this pull request Mar 26, 2020
@seratch
Merge pull request #445 from seratch/migration-guide-ja
ffb48ee 
Add Japanese version to PR #442
@beaufour beaufour mentioned this pull request Dec 19, 2023
Closed
This was referenced Dec 19, 2023
Open
Open
@chrismilleruk chrismilleruk mentioned this pull request Dec 20, 2023
Open
This was referenced Mar 26, 2024
Open
Open
@chrismilleruk chrismilleruk mentioned this pull request Mar 26, 2024
Open
@beaufour beaufour mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch left review comments

@aoberoi aoberoi aoberoi approved these changes

@shaydewael shaydewael Awaiting requested review from shaydewael

Assignees
No one assigned
Labels
docs M-T: Documentation work only semver:major
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengill @seratch @aoberoi