Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added processBeforeResponse flag to ExpressReceiver for FaaS use case #444

Merged

Conversation

stevengill
Copy link
Member

Summary

added processBeforeResponse flag to ExpressReceiver to better support Function as a service use case.

Todo:

  • add docs
  • add tests

Requirements (place an x in each [ ])

@stevengill stevengill changed the title added processBeforeResponse flag to ExpressReceiver for Faas use case added processBeforeResponse flag to ExpressReceiver for FaaS use case Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #444 into @slack/bolt@next will decrease coverage by 1.33%.
The diff coverage is 17.64%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           @slack/bolt@next     #444      +/-   ##
====================================================
- Coverage             86.05%   84.72%   -1.34%     
====================================================
  Files                     7        7              
  Lines                   538      550      +12     
  Branches                157      163       +6     
====================================================
+ Hits                    463      466       +3     
- Misses                   48       57       +9     
  Partials                 27       27              
Impacted Files Coverage Δ
src/ExpressReceiver.ts 66.97% <12.50%> (-5.48%) ⬇️
src/App.ts 89.25% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628cda8...0f9c342. Read the comment docs.

src/ExpressReceiver.ts Outdated Show resolved Hide resolved
@seratch
Copy link
Member

seratch commented Mar 26, 2020

This PR is addressing #395 Thank you @stevengill for working on this!

src/App.ts Outdated Show resolved Hide resolved
src/ExpressReceiver.ts Outdated Show resolved Hide resolved
@seratch seratch added enhancement M-T: A feature request for new functionality semver:major labels Mar 26, 2020
@seratch seratch modified the milestones: V2, v2.0, v2.1 Mar 26, 2020
@aoberoi aoberoi modified the milestones: v2.1, v2.0 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants