Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type aliases (RadioButton and Checkbox) for convenient. #471

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

yoichiro
Copy link
Contributor

@yoichiro yoichiro commented Apr 14, 2020

Summary

The BlockElementAction already has two types ( RadioButtonsAction and CheckboxesAction ) which were added recently. However, we currently need to specify them as a parameterized type for BlockAction, because there are no type aliases for them.

We will be able to use them more convenient, if their type aliases are provided.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files           7        7           
  Lines         552      552           
  Branches      163      163           
=======================================
  Hits          465      465           
  Misses         60       60           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d9476...6c3d422. Read the comment docs.

@stevengill
Copy link
Member

Thanks for sending this in @yoichiro! Merging it now

@stevengill stevengill merged commit a70a3a8 into slackapi:master Apr 14, 2020
@yoichiro yoichiro deleted the add-some-aliases branch April 14, 2020 23:55
@yoichiro
Copy link
Contributor Author

@stevengill Thank you for the reviewing and merging! :)

@seratch
Copy link
Member

seratch commented Apr 15, 2020

@yoichiro Thanks for taking the time to make this change! I'm glad to see more contributions from Japan in these days 😄

@yoichiro
Copy link
Contributor Author

@seratch Thank you! And, it would be great if you confirm it, because I submitted the new issue: slackapi/node-slack-sdk#993 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants