Add middleware matching app_mention events' text #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
approved these changes
May 18, 2020
seratch
changed the title
aoberoi
suggested changes
May 20, 2020
hashedhyphen
force-pushed
the
feat/match-app-mention
branch
from
ae0f4ff
to
7defbd2
Compare
aoberoi
approved these changes
May 27, 2020
|
This looks great @hashedhyphen! Thanks for following through with this from reporting the problem, to conceptualizing a solution, implementing it, testing it, and revising it based on feedback 👏 |
stevengill
approved these changes
May 27, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #489
This PR is for a new middleware to filter
app_mention-event texts, based on feedback in #489.cc: @seratch @stevengill
Requirements (place an
xin each[ ])