Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docs issue with generateInstallUrl for OAuth #527

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

stevengill
Copy link
Member

Summary

Fixes issue #526

Requirements (place an x in each [ ])

@stevengill stevengill added the docs M-T: Documentation work only label Jun 25, 2020
@stevengill stevengill requested a review from seratch June 25, 2020 00:00
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging this, I will update the corresponding JA page.

docs/_basic/authenticating_oauth.md Outdated Show resolved Hide resolved
@stevengill
Copy link
Member Author

@seratch ready for another review

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8bd5f78). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #527   +/-   ##
=========================================
  Coverage          ?   83.13%           
=========================================
  Files             ?        7           
  Lines             ?      593           
  Branches          ?      184           
=========================================
  Hits              ?      493           
  Misses            ?       68           
  Partials          ?       32           
Impacted Files Coverage Δ
src/middleware/builtin.ts 82.78% <0.00%> (ø)
src/ExpressReceiver.ts 65.21% <0.00%> (ø)
src/App.ts 87.82% <0.00%> (ø)
src/middleware/process.ts 100.00% <0.00%> (ø)
src/conversation-store.ts 100.00% <0.00%> (ø)
src/errors.ts 100.00% <0.00%> (ø)
src/helpers.ts 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd5f78...163949e. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I will make another PR for the corresponding JA page.

@stevengill stevengill merged commit f9659e8 into slackapi:master Jul 2, 2020
seratch added a commit to seratch/bolt-js that referenced this pull request Jul 3, 2020
@seratch seratch mentioned this pull request Jul 3, 2020
2 tasks
stevengill added a commit that referenced this pull request Jul 3, 2020
Apply #527 changes to Japanese docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants