-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed docs issue with generateInstallUrl for OAuth #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging this, I will update the corresponding JA page.
@seratch ready for another review |
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=========================================
Coverage ? 83.13%
=========================================
Files ? 7
Lines ? 593
Branches ? 184
=========================================
Hits ? 493
Misses ? 68
Partials ? 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I will make another PR for the corresponding JA page.
Apply #527 changes to Japanese docs
Summary
Fixes issue #526
Requirements (place an
x
in each[ ]
)