Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added v1 runtime deprecation notice #533

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

stevengill
Copy link
Member

@stevengill stevengill commented Jun 30, 2020

Summary

Added runtime deprecation notice for bolt v1. This will only be applied to the v1 branch.

A new bolt@v1 release will be needed.

Issue: #528

Requirements (place an x in each [ ])

@stevengill stevengill requested a review from aoberoi June 30, 2020 05:55
@stevengill stevengill self-assigned this Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #533 into v1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #533   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files           7        7           
  Lines         544      544           
  Branches      158      158           
=======================================
  Hits          434      434           
  Misses         80       80           
  Partials       30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a527d...5a9ab88. Read the comment docs.

@stevengill stevengill linked an issue Jun 30, 2020 that may be closed by this pull request
6 tasks
@stevengill stevengill removed a link to an issue Jun 30, 2020
6 tasks
@seratch seratch added the v1 label Jun 30, 2020
@stevengill stevengill merged commit 64fffe5 into slackapi:v1 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants