Add userScopes to AppOptions

[joshmcgrath08]

• Support for userScopes is already provided by @slack/oauth

Summary

This PR adds "userScopes" to AppOptions so that they may be populated when using the /slack/install resource.

Requirements (place an x in each [ ])

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #540 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files           7        7           
  Lines         593      593           
  Branches      184      184           
=======================================
  Hits          493      493           
  Misses         68       68           
  Partials       32       32           

Impacted Files	Coverage Δ
src/ExpressReceiver.ts	65.21% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b37456...278cbb2. Read the comment docs.

[joshmcgrath08]

Related issue: #541

[seratch]

LGTM but I'd like to have other maintainers' reviews before merging this.

[stevengill]

Hey @joshmcgrath08!

Thanks for sending this in. Seems like a great addition. Only change I'd like to request is that instead of making userScopes top level in AppOptions, we instead put it inside of the installerOptions object. The idea is that we keep the minimum and most common options top level in App Options and move the rest of the OAuth related options into installerOptions. Do you mind making that change?

[joshmcgrath08]

Thanks for the quick feedback. Happy to make that change. I'll update the pr tonight.

…

On Tue, Jul 7, 2020, 2:25 PM Steve Gill ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hey @joshmcgrath08 <https://github.com/joshmcgrath08>! Thanks for sending this in. Seems like a great addition. Only change I'd like to request is that instead of making userScopes top level in AppOptions, we instead put it inside of the installerOptions object. The idea is that we keep the minimum and most common options top level in App Options and move the rest of the OAuth related options into installerOptions. Do you mind making that change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#540 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATUU5ENOJAA5HFHNWS37DLR2NSAPANCNFSM4ORBC3VQ> .

[joshmcgrath08]

@stevengill I moved userScopes under installerOptions as discussed. Thanks for the suggestion--it looks much cleaner.

[stevengill]

Thanks for making the changes. Looks good to me