You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've searched for any related issues and avoided creating a duplicate issue.
Enhancement
It looks like, while the RTM client is configurable with HUBOT_SLACK_RTM_CLIENT_OPTS, this module does not expose any way to configure the web client.
The code merely hard codes maxRequestConcurrency to 1 and provides no opportunity to enable other options, such as debug logging.
Based on the underlying node-slack-sdk using a default of 10 for max request concurrency, it might be best to remove the setting entirely from this code and fall back to the whatever the node-slack-sdk uses for default.
iancward
added a commit
to iancward/hubot-slack
that referenced
this issue
May 17, 2019
Add new HUBOT_SLACK_WEB_CLIENT_OPTS environment variable, used to
configure web client options; It should be functionally similar to
HUBOT_SLACK_RTM_CLIENT_OPTS, which is used to configure the RTM Client
iancward
added a commit
to iancward/hubot-slack
that referenced
this issue
May 17, 2019
Description
Describe your issue here.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Enhancement
It looks like, while the RTM client is configurable with
HUBOT_SLACK_RTM_CLIENT_OPTS
, this module does not expose any way to configure the web client.The code merely hard codes
maxRequestConcurrency
to1
and provides no opportunity to enable other options, such as debug logging.See https://github.com/slackapi/hubot-slack/blob/master/src/client.coffee#L29-L30.
Can something like a
HUBOT_SLACK_WEB_CLIENT_OPTS
environment variable be created and used when the web client is being initialized?The text was updated successfully, but these errors were encountered: