Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Web Client Options #558

Open
4 of 9 tasks
iancward opened this issue Apr 2, 2019 · 2 comments
Open
4 of 9 tasks

Expose Web Client Options #558

iancward opened this issue Apr 2, 2019 · 2 comments
Labels
enhancement M-T: A feature request for new functionality
Milestone

Comments

@iancward
Copy link

iancward commented Apr 2, 2019

Description

Describe your issue here.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Enhancement

It looks like, while the RTM client is configurable with HUBOT_SLACK_RTM_CLIENT_OPTS, this module does not expose any way to configure the web client.
The code merely hard codes maxRequestConcurrency to 1 and provides no opportunity to enable other options, such as debug logging.

See https://github.com/slackapi/hubot-slack/blob/master/src/client.coffee#L29-L30.

Can something like a HUBOT_SLACK_WEB_CLIENT_OPTS environment variable be created and used when the web client is being initialized?

@iancward
Copy link
Author

iancward commented Apr 2, 2019

Also, is there any reason why the concurrency is set to 1? The documentation seems to indicate the default is 10 https://slack.dev/node-slack-sdk/web-api#request-concurrency.

@iancward
Copy link
Author

iancward commented Apr 2, 2019

Based on the underlying node-slack-sdk using a default of 10 for max request concurrency, it might be best to remove the setting entirely from this code and fall back to the whatever the node-slack-sdk uses for default.

iancward added a commit to iancward/hubot-slack that referenced this issue May 17, 2019
Add new HUBOT_SLACK_WEB_CLIENT_OPTS environment variable, used to
configure web client options; It should be functionally similar to
HUBOT_SLACK_RTM_CLIENT_OPTS, which is used to configure the RTM Client
iancward added a commit to iancward/hubot-slack that referenced this issue May 17, 2019
@seratch seratch added the enhancement M-T: A feature request for new functionality label Apr 14, 2020
@seratch seratch added this to the 4.9.0 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants