Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversations.externalInvitePermissions.set API support #1330

Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 25, 2024

This pull request adds a new endpoint to this SDK:
https://api.slack.com/methods/conversations.externalInvitePermissions.set

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Jun 25, 2024
@seratch seratch added this to the 1.40.2 milestone Jun 25, 2024
@seratch seratch requested a review from filmaj June 25, 2024 02:29
@seratch seratch self-assigned this Jun 25, 2024
@seratch
Copy link
Member Author

seratch commented Jun 25, 2024

@filmaj The JSON data output will be necessary for Node SDK work. If you don't see any issues with the changes here, please feel free to merge this PR into main branch tomorrow

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (1b6030e) to head (31e4863).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1330      +/-   ##
============================================
+ Coverage     74.91%   74.93%   +0.01%     
- Complexity     4171     4176       +5     
============================================
  Files           446      446              
  Lines         12902    12912      +10     
  Branches       1331     1331              
============================================
+ Hits           9665     9675      +10     
  Misses         2461     2461              
  Partials        776      776              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! I was actually looking at past PRs in this past project yesterday to figure out: what is the correct process to add a new API to the Java SDK, and thus to also get a response payload into the project for use in generation scripts in the node SDK?

Did you generate the sample JSON in this PR manually?

The reason I ask is that there are several more APIs that we will need to add in the near future, so I'd like to know how it is done. Recently I would send PRs containing only the sample JSON, but with more coming, I would like to know the process you use to approach this problem. In the mean time, I will work backwards from this PR as a guide.

@filmaj filmaj merged commit 31a1f97 into slackapi:main Jun 25, 2024
6 checks passed
@seratch
Copy link
Member Author

seratch commented Jun 25, 2024

The e2e tests in this repo automatically detect missing properties plus generate JSON files for you.

You need to set up necessary env variables to run the tests but no need to perfectly set up all the things. When you add a new test with sufficient tokens, running the test generates the sample files based on the latest responses from Slack API server.

@filmaj
Copy link
Contributor

filmaj commented Jun 25, 2024

Awesome! Thank you for confirming 🙇

@seratch seratch deleted the conversations.externalInvitePermissions.set branch June 26, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants