-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversations.externalInvitePermissions.set API support #1330
Add conversations.externalInvitePermissions.set API support #1330
Conversation
@filmaj The JSON data output will be necessary for Node SDK work. If you don't see any issues with the changes here, please feel free to merge this PR into main branch tomorrow |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
============================================
+ Coverage 74.91% 74.93% +0.01%
- Complexity 4171 4176 +5
============================================
Files 446 446
Lines 12902 12912 +10
Branches 1331 1331
============================================
+ Hits 9665 9675 +10
Misses 2461 2461
Partials 776 776 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! I was actually looking at past PRs in this past project yesterday to figure out: what is the correct process to add a new API to the Java SDK, and thus to also get a response payload into the project for use in generation scripts in the node SDK?
Did you generate the sample JSON in this PR manually?
The reason I ask is that there are several more APIs that we will need to add in the near future, so I'd like to know how it is done. Recently I would send PRs containing only the sample JSON, but with more coming, I would like to know the process you use to approach this problem. In the mean time, I will work backwards from this PR as a guide.
The e2e tests in this repo automatically detect missing properties plus generate JSON files for you. You need to set up necessary env variables to run the tests but no need to perfectly set up all the things. When you add a new test with sufficient tokens, running the test generates the sample files based on the latest responses from Slack API server. |
Awesome! Thank you for confirming 🙇 |
This pull request adds a new endpoint to this SDK:
https://api.slack.com/methods/conversations.externalInvitePermissions.set
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.