Fix #1336 missing and invalid properties in rich text block elements #1337
Conversation
seratch
added
bug
| private final String type = TYPE; | ||
| private String url; | ||
| private String text; | ||
| private Boolean unsafe; |
| private String format; | ||
| private TextStyle style; | ||
| private String url; | ||
| private String fallback; |
There was a problem hiding this comment.
Added this missing property too
| public static final String TYPE = "date"; | ||
| private final String type = TYPE; | ||
| private String timestamp; | ||
| private String format; |
There was a problem hiding this comment.
Added this missing property too
| @@ -42,7 +69,7 @@ public static class Channel implements RichTextElement { | |||
| public static final String TYPE = "channel"; | |||
| private final String type = TYPE; | |||
| private String channelId; // C12345678 | |||
| private TextStyle style; | |||
| private NoCodeTextStyle style; | |||
There was a problem hiding this comment.
channel, user, usergroup, team, broadcast, color do not accept code property
| @@ -146,7 +150,23 @@ public static class TextStyle { | |||
| private boolean bold; | |||
| private boolean italic; | |||
| private boolean strike; | |||
| private boolean highlight; | |||
There was a problem hiding this comment.
these are not mentioned in the documents but actually these properties work for all elements
There was a problem hiding this comment.
🤔 this makes sense, from what I was able to find there are currently only 2 versions of these style objects
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public static class NoCodeTextStyle { |
There was a problem hiding this comment.
Added this for the ones that do not accept code
There was a problem hiding this comment.
It seems like this object may be referenced as limited_style, what do you think about naming this LimitedTextStyle?
| public static class NoCodeTextStyle { | |
| public static class LimitedTextStyle { |
There was a problem hiding this comment.
Sounds good. Renamed it.
| @Test | ||
| public void parseRichTextElements() { | ||
| String json = "{\n" + | ||
| " \"blocks\": [\n" + |
There was a problem hiding this comment.
Used this JSON data in Block Kit Builder for verifying
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
============================================
+ Coverage 74.77% 74.81% +0.03%
- Complexity 4177 4181 +4
============================================
Files 451 451
Lines 12930 12930
Branches 1331 1331
============================================
+ Hits 9668 9673 +5
+ Misses 2487 2483 -4
+ Partials 775 774 -1 ☔ View full report in Codecov by Sentry. |
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public static class NoCodeTextStyle { |
There was a problem hiding this comment.
It seems like this object may be referenced as limited_style, what do you think about naming this LimitedTextStyle?
| public static class NoCodeTextStyle { | |
| public static class LimitedTextStyle { |
| @@ -146,7 +150,23 @@ public static class TextStyle { | |||
| private boolean bold; | |||
| private boolean italic; | |||
| private boolean strike; | |||
| private boolean highlight; | |||
There was a problem hiding this comment.
🤔 this makes sense, from what I was able to find there are currently only 2 versions of these style objects
This pull request resolves #1336
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.