Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1343 block_suggestion response does not support description in an option #1351

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 20, 2024

This pull request resolves #1343

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-app-backend labels Aug 20, 2024
@seratch seratch added this to the 1.41.0 milestone Aug 20, 2024
@seratch seratch self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.99%. Comparing base (11a6def) to head (4001b78).
Report is 1 commits behind head on main.

Files Patch % Lines
...ackend/interactive_components/response/Option.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1351      +/-   ##
============================================
- Coverage     74.99%   74.99%   -0.01%     
- Complexity     4189     4190       +1     
============================================
  Files           451      452       +1     
  Lines         12929    12931       +2     
  Branches       1331     1331              
============================================
+ Hits           9696     9697       +1     
- Misses         2462     2463       +1     
  Partials        771      771              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit efa3f24 into slackapi:main Aug 20, 2024
5 of 6 checks passed
@seratch seratch deleted the issue-1343-option-description branch August 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block_suggestion response does not support description in an option
1 participant