Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1363 Wrong element type for timestamp in RichTextSectionElement.Date #1364

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Fix #1363 Wrong element type for timestamp in RichTextSectionElement.Date #1364

merged 5 commits into from
Sep 10, 2024

Conversation

jed204
Copy link
Contributor

@jed204 jed204 commented Sep 9, 2024 •
edited by seratch
Loading

This pull request resolves #1363

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Sep 9, 2024

Thanks for the contribution! Before we can merge this, we need @jed204 to sign the Salesforce Inc. Contributor License Agreement.

WilliamBergamin
WilliamBergamin approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

Please sign the CLA

slack-api-model/src/main/java/com/slack/api/model/block/element/RichTextSectionElement.java
@@ -54,7 +54,7 @@ public static class Link implements RichTextElement {
public static class Date implements RichTextElement {
public static final String TYPE = "date";
private final String type = TYPE;
private String timestamp;
private Long timestamp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 💯 I think this may be an integer on the backend, but this project uses Long for other timestamp values

@jed204
Copy link
Contributor Author

jed204 commented Sep 9, 2024

Thank you for the contribution 🙏

Please sign the CLA

I signed it but there was an error when I submitted - when I try to sign it again it says I signed it already. Any ideas?

@WilliamBergamin
Copy link
Contributor

I see, don't worry about the CLA for now
It seems like some tests are failing, we will need to fix these before merging

WilliamBergamin
WilliamBergamin requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to pass 🙏

@seratch seratch closed this Sep 10, 2024
@seratch seratch reopened this Sep 10, 2024
@jed204
Copy link
Contributor Author

jed204 commented Sep 10, 2024

Tests need to pass 🙏

Roger. I updated the mock responses. They are passing locally now.

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (71abd20) to head (26b659a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1364   +/-   ##
=========================================
  Coverage     74.77%   74.77%           
  Complexity     4270     4270           
=========================================
  Files           457      457           
  Lines         13278    13278           
  Branches       1369     1369           
=========================================
  Hits           9929     9929           
  Misses         2548     2548           
  Partials        801      801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seratch
seratch approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending this PR!

@seratch seratch merged commit 5338d57 into slackapi:main Sep 10, 2024
6 checks passed
@seratch seratch changed the title Fix for Issue #1363 Fix #1363 Wrong element type for timestamp in RichTextSectionElement.Date Sep 10, 2024
@seratch seratch added this to the 1.42.1 milestone Sep 10, 2024
@KENNYSOFT KENNYSOFT mentioned this pull request Sep 19, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin requested changes

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
1.42.1
Development

Successfully merging this pull request may close these issues.

Wrong element type for timestamp in RichTextSectionElement.Date
3 participants
@jed204 @WilliamBergamin @seratch