Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially reverting #441 - get @EqualsAndHashCode(callSuper = false) back for data classes #442

Merged
merged 4 commits into from
May 2, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 2, 2020

Summary

This pull request partially reverts #441 (this PR was really amazing).

As having @EqualsAndHashCode(callSuper = false) annotation in @Data classes was intentional (I totally forgot it when reviewing the PR), the commit to remove them should be reverted. See also: #441 (comment)

cc @eamelink

Requirements (place an x in each [ ])

@seratch seratch self-assigned this May 2, 2020
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #442 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     83.95%   83.98%   +0.03%     
  Complexity     2370     2370              
============================================
  Files           250      250              
  Lines          6376     6376              
  Branches        578      578              
============================================
+ Hits           5353     5355       +2     
+ Misses          669      665       -4     
- Partials        354      356       +2     
Impacted Files Coverage Δ Complexity Δ
...i/bolt/context/builtin/BlockSuggestionContext.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...slack/api/bolt/context/builtin/DefaultContext.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../bolt/context/builtin/DialogSubmissionContext.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../bolt/context/builtin/DialogSuggestionContext.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../api/bolt/context/builtin/SlashCommandContext.java 60.00% <ø> (ø) 6.00 <0.00> (ø)
...pi/bolt/context/builtin/ViewSubmissionContext.java 77.77% <ø> (ø) 13.00 <0.00> (ø)
...in/java/com/slack/api/audit/AuditApiException.java 81.81% <ø> (+9.09%) 6.00 <0.00> (ø)
.../slack/api/methods/MethodsCompletionException.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../java/com/slack/api/methods/SlackApiException.java 81.81% <ø> (+18.18%) 6.00 <0.00> (+1.00)
...main/java/com/slack/api/scim/SCIMApiException.java 72.72% <ø> (ø) 6.00 <0.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0d180...3bd2bfc. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented May 2, 2020

Also, I need to add @EqualsAndHashCode(callSuper=false) to the ones that used to have callSuper=true. Will do.

@eamelink
Copy link
Contributor

eamelink commented May 2, 2020

Ah, I had overlooked that! Thanks :)

Having the equality fixed is great; I use it for tests of my library that generates blocks :)

@seratch seratch merged commit bf10d2c into slackapi:master May 2, 2020
@seratch seratch deleted the pr-441-revert branch May 2, 2020 10:55
@seratch seratch added this to the 1.0.x milestone May 8, 2020
seratch added a commit that referenced this pull request May 8, 2020
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] #449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants