-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially reverting #441 - get @EqualsAndHashCode(callSuper = false) back for data classes #442
Conversation
This reverts commit 41294ce.
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
============================================
+ Coverage 83.95% 83.98% +0.03%
Complexity 2370 2370
============================================
Files 250 250
Lines 6376 6376
Branches 578 578
============================================
+ Hits 5353 5355 +2
+ Misses 669 665 -4
- Partials 354 356 +2
Continue to review full report at Codecov.
|
Also, I need to add |
Ah, I had overlooked that! Thanks :) Having the equality fixed is great; I use it for tests of my library that generates blocks :) |
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] #449 Add attachement.author_id - thanks @seratch * [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch * [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Summary
This pull request partially reverts #441 (this PR was really amazing).
As having
@EqualsAndHashCode(callSuper = false)
annotation in@Data
classes was intentional (I totally forgot it when reviewing the PR), the commit to remove them should be reverted. See also: #441 (comment)cc @eamelink
Requirements (place an
x
in each[ ]
)