Fix #477 by adding default_to_current_conversation to conv elements #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
============================================
+ Coverage 83.80% 83.86% +0.06%
- Complexity 2413 2414 +1
============================================
Files 251 251
Lines 6482 6482
Branches 585 585
============================================
+ Hits 5432 5436 +4
+ Misses 687 683 -4
Partials 363 363
Continue to review full report at Codecov.
|
seratch
added a commit
that referenced
this pull request
Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
seratch
added a commit
that referenced
this pull request
Jun 11, 2020
* [slack-api-model] #477 #478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] #487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] #486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] #480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-model] slackapi#477 slackapi#478 Add default_to_current_conversation in (multi_)conversations_select - Thanks @seratch * [slack-api-client] slackapi#487 Add admin.conversations.whitelist.* API - Thanks @seratch * [slack-api-client] slackapi#486 Move UsersLookupByEmailResponse to the right package (source code compatible) - Thanks @seratch * [slack-api-client] slackapi#480 Fix potential false detection of subtypes in RTMClient - Thanks @gaspardpetit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #477 by adding the
default_to_current_conversationflag to conversation_select / multi_conversation_select block elements.Requirements (place an
xin each[ ])