-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #676 Add an easier way to access Events API retry info #677
Conversation
…ack-Retry-Reason in Bolt apps
@@ -15,4 +15,11 @@ | |||
|
|||
private String channelId; | |||
|
|||
// X-Slack-Retry-Num: 2 in HTTP Mode | |||
// "retry_attempt": 0, in Socket Mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevengill @mwbrooks
The names are a bit different here. Do we prefer retryAttempt
? I personally feel retryNum
is fine as it's a number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer to keep the names consistent between the headers and variables. It makes it easier to understand that the two are identical and intended to match. So I'd lean toward retryNum
as well.
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
============================================
+ Coverage 78.79% 78.86% +0.06%
- Complexity 3052 3060 +8
============================================
Files 331 331
Lines 8830 8847 +17
Branches 833 839 +6
============================================
+ Hits 6958 6977 +19
+ Misses 1364 1363 -1
+ Partials 508 507 -1
Continue to review full report at Codecov.
|
@@ -15,4 +15,11 @@ | |||
|
|||
private String channelId; | |||
|
|||
// X-Slack-Retry-Num: 2 in HTTP Mode | |||
// "retry_attempt": 0, in Socket Mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer to keep the names consistent between the headers and variables. It makes it easier to understand that the two are identical and intended to match. So I'd lean toward retryNum
as well.
Any plans on adding this for boltjs? |
This pull request enables Events API listeners to access x-slack-retry-num / x-slack-retry-reason header values (retry_attempt / retry_reason in Socket Mode) in the following way.
Fixes #676
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.