Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Adding support for pre-parsed requests #90

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

pichsenmeister
Copy link
Member

Summary

Some server-less cloud providers (e.g. Google Firebase Cloud Functions) are populating the request with a body parser before it can be parsed by the SDK. To prevent the middleware of throwing an error, it checks the request if it exposes a raw body in the request.rawBody variable.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #90 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #90     +/-   ##
=========================================
+ Coverage   95.41%   95.62%   +0.2%     
=========================================
  Files           4        4             
  Lines         131      137      +6     
=========================================
+ Hits          125      131      +6     
  Misses          6        6
Impacted Files Coverage Δ
src/http-handler.js 94.5% <100%> (+0.83%) ⬆️
src/adapter.js 97.5% <100%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87707ef...7780c82. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Feb 14, 2019

this looks great! i think the travis failure for node v4.2 is a false negative because we shouldn't be testing on that version (v4 branch is working).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants