chore (types): small refactorings and two new helper types #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching towards tackling breaking changes / prep for major release of types.
filmaj
added
semver:minor
area:typescript
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 35 35
Lines 7745 7745
Branches 317 317
=======================================
Hits 6333 6333
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
zimeg
approved these changes
Jun 17, 2024
| @@ -50,6 +50,7 @@ export interface Block { | |||
| */ | |||
| export type KnownBlock = ImageBlock | ContextBlock | ActionsBlock | DividerBlock | | |||
| SectionBlock | InputBlock | FileBlock | HeaderBlock | VideoBlock | RichTextBlock; | |||
|
|
|||
Comment on lines
3
to
11
| /** | ||
| * Re-usable labels for common color schemes present in Slack. `danger` displays with a red background (red text on | ||
| * mobile), while `primary` displays with a green background (green text on mobile). | ||
| */ | ||
| export type ColorScheme = 'primary' | 'danger'; | ||
|
|
||
| /** The conversation type as available within the Slack UI. */ | ||
| export type Conversation = 'im' | 'mpim' | 'private' | 'public'; | ||
|
|
| interface BaseConversationFilter { | ||
| /** | ||
| * @description Indicates which type of conversations should be included in the list. When this field is provided, any | ||
| * conversations that do not match will be excluded. You should provide an array of strings from the following options: | ||
| * `im`, `mpim`, `private`, and `public`. The array cannot be empty. | ||
| */ | ||
| include?: [Conversation, ...Conversation[]]; // TS gymnastics for "at least one item" |
| @@ -182,6 +180,7 @@ export interface Confirmation { | |||
| title?: string; | |||
| } | |||
|
|
|||
| // Used in web-api chat.* API method request parameters | |||
seratch
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColorScheme,MaxItemsSelectable,RichTextBorderable,URLRespondable, andConversation