Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DataStore #437

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Deprecate DataStore #437

merged 1 commit into from
Dec 21, 2017

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Dec 21, 2017

Summary

This is related to #423 and #330.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #437 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #437      +/-   ##
=========================================
+ Coverage   89.09%   89.1%   +0.01%     
=========================================
  Files          44      44              
  Lines        1256    1258       +2     
  Branches      190     190              
=========================================
+ Hits         1119    1121       +2     
  Misses        137     137
Impacted Files Coverage Δ
lib/clients/web/client.js 100% <ø> (ø) ⬆️
lib/data-store/memory-data-store.js 80.35% <ø> (ø) ⬆️
lib/clients/rtm/client.js 84.21% <ø> (ø) ⬆️
lib/data-store/data-store.js 93.39% <100%> (+0.06%) ⬆️
lib/clients/client.js 90.16% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd1de7...fc34cbb. Read the comment docs.

@aoberoi aoberoi merged commit 5eb9e29 into slackapi:master Dec 21, 2017
@aoberoi aoberoi deleted the deprecate-datastore branch December 21, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant