-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for uploading files #56
Conversation
any hope in getting this merged? |
This would be awesome to have support for! Any updates on what is missing, if anything is? |
sry. wrong post. |
any word on this getting merged? |
@alexkwolfe do you have time to fix the merge conflicts? I want to start nudging people for this again but it seems like its no longer a clean merge. If you don't have time, lemme know and I'll take a stab. |
I'd love to see this merged as well so slackapi/hubot-slack#62 can proceed. |
Can you link me to the hubot issue where that's discussed? Right now, you can upload files via something like:
The way the PR is currently structured would need to be changed around quite a bit, as the pattern of mixing the model objects with API actions (e.g. So, if the issue is the general one of getting an API call to use to upload files, that's pretty simple and I can add a full example to the |
I think the issue is just having an API call to use to upload files, so the |
Gotcha. I'll write up a proper example this week. Thanks for the clarification. |
Is this PR needed any more? I see an example for how to upload files in the example directory. |
I'm going to assume not—I'll open an issue to track this should it turn out that uploading files on 3.x isn't working so hot. |
Support validation of message_action
I rebased #22 on master and fixed up a few of the issues mentioned in that PR.
Also of note is that file uploading is now done with a multipart request. I'm allowing the caller to override the
token
param, which is essential for performing a file upload from a bot. Bots cannot do file uploads so a real user's API token must be provided.I'm looking for feedback on this PR and am happy to make adjustments, etc.