Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short lived tokens #625

Merged
merged 36 commits into from
Aug 30, 2018
Merged

Short lived tokens #625

merged 36 commits into from
Aug 30, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Aug 30, 2018

Summary

The culmination of the work to support short-lived tokens in the WebClient.

Fixes #617

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Aug 30, 2018

Codecov Report

Merging #625 into master will decrease coverage by 0.12%.
The diff coverage is 92.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   92.01%   91.89%   -0.13%     
==========================================
  Files           7        7              
  Lines         426      481      +55     
  Branches       78       89      +11     
==========================================
+ Hits          392      442      +50     
- Misses         19       22       +3     
- Partials       15       17       +2
Impacted Files Coverage Δ
src/methods.ts 100% <ø> (ø) ⬆️
src/errors.ts 100% <100%> (ø) ⬆️
src/WebClient.ts 93.75% <92.13%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95f59c...bbcb2ef. Read the comment docs.

@shaydewael shaydewael merged commit d76a7be into master Aug 30, 2018
@shaydewael shaydewael deleted the feat-short-lived-tokens branch August 30, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants