Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #964 Add types for checkboxes #966

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 17, 2020

Summary

This pull request fixes #964 by adding a type for the checkboxes type block element. The radion_buttons one already exists.

Requirements (place an x in each [ ])

@seratch seratch added semver:minor enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` labels Feb 17, 2020
@seratch seratch self-assigned this Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #966 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage    94.8%   94.87%   +0.06%     
==========================================
  Files          12       12              
  Lines         732      741       +9     
  Branches      166      166              
==========================================
+ Hits          694      703       +9     
  Misses         13       13              
  Partials       25       25
Flag Coverage Δ
#eventsapi 89.61% <ø> (-10.39%) ⬇️
#interactivemessages 94.92% <ø> (-5.08%) ⬇️
#webapi 97.88% <ø> (ø) ⬆️
#webhook 87.5% <ø> (+1.38%) ⬆️
Impacted Files Coverage Δ
src/index.ts 87.5% <0%> (ø) ⬆️
src/http-handler.ts 90.57% <0%> (ø) ⬆️
src/util.ts 89.47% <0%> (ø) ⬆️
src/errors.ts 100% <0%> (ø) ⬆️
src/adapter.ts 95.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01190ab...83c012c. Read the comment docs.

@stevengill stevengill merged commit 4663d74 into slackapi:master Feb 18, 2020
@seratch seratch deleted the checkboxes branch February 18, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add types for radio buttons and checkboxes
2 participants