Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added package prefix to logger name #999

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

stevengill
Copy link
Member

Summary

Fix for issue #995

Requirements (place an x in each [ ])

@stevengill stevengill added semver:patch pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` labels Apr 23, 2020
@stevengill stevengill self-assigned this Apr 23, 2020
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          12       12           
  Lines         768      768           
  Branches      173      173           
=======================================
  Hits          725      725           
  Misses         14       14           
  Partials       29       29           
Flag Coverage Δ
#eventsapi 89.61% <ø> (ø)
#interactivemessages 95.04% <ø> (ø)
#webapi 96.36% <ø> (ø)
#webhook 87.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c55d6...ba1f27a. Read the comment docs.

@stevengill stevengill merged commit 222e21b into slackapi:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:rtm-api applies to `@slack/rtm-api` pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants