Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install async (optional) dependencies in 3.26.2 #1455

Closed
drasmuss opened this issue Jan 30, 2024 · 1 comment · Fixed by #1456
Closed

Can't install async (optional) dependencies in 3.26.2 #1455

drasmuss opened this issue Jan 30, 2024 · 1 comment · Fixed by #1456
Assignees
Labels
area:async bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Milestone

Comments

@drasmuss
Copy link

drasmuss commented Jan 30, 2024

The Slack SDK version

slack_sdk==3.26.2

Python runtime version

Python 3.9.16

OS info

N/A

Steps to reproduce:

  1. pip install slack_sdk[optional]==3.26.2

Expected result:

Installation with asyncio dependencies included, as described in https://github.com/slackapi/python-slack-sdk?tab=readme-ov-file#dns-performance.

Actual result:

WARNING: slack-sdk 3.26.2 does not provide the extra 'optional', asyncio dependencies aren't installed, and attempting to use that functionality results in an error.

Note: this change was introduced in 69638bf#diff-aa105879908fd2bb65240fade83175ff1ed8f7a989981cd1d5277ad842908afe. In that PR the optional requirements were moved to requirements/optional.txt, but that requires users to clone the repo and then manually install using that requirements file, which is pretty inconvenient.

@drasmuss drasmuss changed the title Can't install async (optional) dependencies in 3.26 Can't install async (optional) dependencies in 3.26.2 Jan 30, 2024
@WilliamBergamin
Copy link
Contributor

Hi @drasmuss thanks for writing in 💯

This is a great catch, I'll work on a fix and have it out soon

@WilliamBergamin WilliamBergamin added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented area:async and removed untriaged labels Jan 30, 2024
@WilliamBergamin WilliamBergamin self-assigned this Jan 30, 2024
@seratch seratch added this to the 3.27.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants