Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional dependency install #1456

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR aims to fix #1455 by exposing the dependencies found in requirements/optional.txt

I've deployed these changes to https://test.pypi.org/project/slack-sdk/3.26.3a0/

You can test them out by executing pip3 install -i https://test.pypi.org/simple/ 'slack-sdk[optional]==3.26.3a0'
NOTE: the install will fail since not all of the dependencies in requirements/optional.txt are in test.pypi.org

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jan 30, 2024
@WilliamBergamin WilliamBergamin self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc96f5f) 85.34% compared to head (47a0f0d) 85.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
- Coverage   85.34%   85.34%   -0.01%     
==========================================
  Files         111      111              
  Lines       12273    12273              
==========================================
- Hits        10475    10474       -1     
- Misses       1798     1799       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added this to the 3.26.3 milestone Jan 31, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 00bb7cd into slackapi:main Jan 31, 2024
12 checks passed
@seratch seratch modified the milestones: 3.26.3, 3.27.0 Jan 31, 2024
@WilliamBergamin WilliamBergamin deleted the fix-optional-dependecies branch January 31, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install async (optional) dependencies in 3.26.2
2 participants