Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1446: monitor dies when exceptions raised before monitor created. #1447

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

woolen-sheep
Copy link
Contributor

Summary

  • Fix the problem of monitor dies if an exception raised during reconnect before monitor created.
  • Add a unit test test_interactions_with_disconnection for Slack server side request to disconnect.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@woolen-sheep
Copy link
Contributor Author

  • Fix the problem of monitor dies if an exception raised during reconnect before monitor created.
  • Add a unit test test_interactions_with_disconnection for Slack server side request to disconnect.

cc @hello-ashleyintech , please kindly review this and do necessary tests if you want.

@filmaj filmaj requested a review from seratch January 3, 2024 19:46
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ebdfe45) 85.61% compared to head (a387a74) 85.67%.
Report is 1 commits behind head on main.

Files Patch % Lines
slack_sdk/socket_mode/aiohttp/__init__.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
+ Coverage   85.61%   85.67%   +0.06%     
==========================================
  Files         111      111              
  Lines       12128    12137       +9     
==========================================
+ Hits        10383    10398      +15     
+ Misses       1745     1739       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Jan 8, 2024
@seratch seratch added this to the 3.26.2 milestone Jan 8, 2024
@seratch
Copy link
Member

seratch commented Jan 8, 2024

Thank you so much for taking the time to send this PR. I am (and will be for a while) out of the office now, but will check the changes within a few business days.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for improving this! Looks good to me

slack_sdk/socket_mode/aiohttp/__init__.py Outdated Show resolved Hide resolved
@seratch seratch self-assigned this Jan 9, 2024
@seratch seratch merged commit b6b9527 into slackapi:main Jan 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed socket-mode Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants