-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1446: monitor dies when exceptions raised before monitor created. #1447
Conversation
cc @hello-ashleyintech , please kindly review this and do necessary tests if you want. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
+ Coverage 85.61% 85.67% +0.06%
==========================================
Files 111 111
Lines 12128 12137 +9
==========================================
+ Hits 10383 10398 +15
+ Misses 1745 1739 -6 ☔ View full report in Codecov by Sentry. |
Thank you so much for taking the time to send this PR. I am (and will be for a while) out of the office now, but will check the changes within a few business days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for improving this! Looks good to me
Summary
test_interactions_with_disconnection
for Slack server side request to disconnect.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.