-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add download badge in readme #1449
feat: add download badge in readme #1449
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage 85.65% 85.66%
=======================================
Files 111 111
Lines 12137 12137
=======================================
+ Hits 10396 10397 +1
+ Misses 1741 1740 -1 ☔ View full report in Codecov by Sentry. |
I noticed the contact/support badge is not visible in the badges rendered on your fork. Assuming that's intentional? |
I believe it should be intentional. If so, I am fine with it too as the README mentions the GH issue tracker and community links at the bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the convo about the support link is resolved, you can merge this PR!
@srajiang I don't think the contact/support badge was still relevant, I tested it out and the link redirected me to one of my workspaces /help/requests which seems to be targeted for general slack users not developer specific |
Summary
The goal of this PR is to add the a downloads badge to the readme, the title and badges were also centered.
Testing
look at this fork to see the rendered version
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.