-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new conversations.externalInvitePermissions.set
API
#1517
feat: add new conversations.externalInvitePermissions.set
API
#1517
Conversation
Yours has integration tests! Better than my PR. Let's use this PR instead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 84.89% 84.90% +0.01%
==========================================
Files 113 113
Lines 12480 12489 +9
==========================================
+ Hits 10595 10604 +9
Misses 1885 1885 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but FYI there are issues with this API when using a bot token, so we should hold off on merging/releasing until this is fixed on the backend.
|
||
sender_approval = sender.conversations_acceptSharedInvite(invite_id=invite["invite_id"], team_id=connect_team_id) | ||
self.assertIsNone(sender_approval["error"]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filmaj @WilliamBergamin To make this test function, perhaps you need to call conversations.approveSharedInvite here. Without that, the followng calls will result in channel_not_found error
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
…/github.com/WilliamBergamin/python-slack-sdk into conversations.externalInvitePermissions.set
slack_sdk/web/async_client.py
Outdated
"target_team": target_team, | ||
} | ||
) | ||
return await self.api_call("conversations.externalInvitePermissions.set", http_verb="GET", params=kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run the generator script to synchronize the changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 🟢
…accept type RichTextBlock
Summary
This is a duplicate of #1516 and adds support for https://api.slack.com/methods/conversations.externalInvitePermissions.set
I did not get a chance to test out the integration tests locally, before noticing this was a duplicate
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.