Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use method core.exportVariable instead of core.set-output #142

Closed
wants to merge 1 commit into from

Conversation

Nergie
Copy link

@Nergie Nergie commented Oct 24, 2022

Summary

Fix #141

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022

CLA assistant check
All committers have signed the CLA.

@seratch seratch added this to the 1.24 milestone Oct 24, 2022
@seratch seratch added the enhancement New feature or request label Oct 24, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaxel
Copy link

flaxel commented Oct 30, 2022

You don't need to change the method. Currently you write to GITHUB_ENV but the previous implementation wrote to GITHUB_OUTPUT. So it's only necessary to bump the action dependency.

@seratch
Copy link
Member

seratch commented Oct 31, 2022

@flaxel Thanks for sharing this and this is great to hear! We can upgrade the version instead. If @Nergie is still interested in revising this PR, we will wait for it. Otherwise, I will come up with a new PR, which just upgrades the module.

@Nergie
Copy link
Author

Nergie commented Oct 31, 2022

Thank @flaxel and @seratch. We don't need to bump the dependencies or change the method to export variables.
@actions/core 1.10.0 fixes the issue. See release notes.
I'll close this PR and the issue #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions: Deprecating set-output commands
5 participants