Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting K2 with Skate + update to IJ 2024.2.1 #1006

Merged
merged 18 commits into from
Oct 9, 2024
Merged

Supporting K2 with Skate + update to IJ 2024.2.1 #1006

merged 18 commits into from
Oct 9, 2024

Conversation

kateliu20
Copy link
Contributor

@kateliu20 kateliu20 commented Oct 2, 2024 •
edited by ZacSweers
Loading

Resolves #735

@ZacSweers ZacSweers changed the title Supporting K2 with Skate Supporting K2 with Skate + update to IJ 2024.2.1 Oct 2, 2024
@ZacSweers
Copy link
Collaborator

Uh oh, I think we have an infinite loop in a test

@kateliu20
Copy link
Contributor Author

kateliu20 commented Oct 3, 2024 •
edited
Loading

Uh oh, I think we have an infinite loop in a test

Failed after 6 hours 🥲 Could it have something to do with this? Should we update the source compatibility to 21?

  • The Java configuration specifies sourceCompatibility='17' but IntelliJ Platform '2024.2.1' requires sourceCompatibility='21'.

I am on java 22, but did we define it somewhere to be 17? I am curious, as I know we have this line here:
sourceCompatibility = releaseVersion.get() but should we set it to something like sourceCompatibility = JavaVersion.VERSION_21 ?

@kateliu20
Copy link
Contributor Author

kateliu20 commented Oct 3, 2024 •
edited
Loading

Or actually, when I run ./gradlew check locally it's getting stuck on SkateTraceReporterTest. Maybe this is the test that's in the infinite loop? Running this test individually also takes forever.

ZacSweers
ZacSweers reviewed Oct 8, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
ZacSweers
ZacSweers reviewed Oct 9, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@kateliu20 kateliu20 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit f08b330 Oct 9, 2024
3 checks passed
@kateliu20 kateliu20 deleted the kl/support_k2_skate branch October 9, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support K2 in Skate
2 participants
@kateliu20 @ZacSweers