Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source blockmapFile from generator task #1026

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Source blockmapFile from generator task #1026

merged 1 commit into from
Oct 10, 2024

Conversation

ZacSweers
Copy link
Collaborator

No description provided.

kateliu20
kateliu20 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@kateliu20 kateliu20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is this new change doing? Are we setting a value to the blockmapFile here?

@ZacSweers
Copy link
Collaborator Author

Yes, we have two tasks here. One generates the file and the other uses it. Before they weren't properly linked, now this plumbs the generated file (an output property) into the second task's input property

@ZacSweers ZacSweers added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 472bc4e Oct 10, 2024
3 checks passed
@ZacSweers ZacSweers deleted the z/blockmapFile branch October 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateliu20 kateliu20 kateliu20 approved these changes

@linhpha linhpha Awaiting requested review from linhpha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZacSweers @kateliu20