Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sortDependencies to 0.9 #1027

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ We've restructured this project! Since its early days as a simple Gradle convent
- Build against gradle-nullaway `2.0.0`.
- Build against Gradle versions plugin `0.51.0`.
- Build against Develocity plugin `3.18.1`.
- Build against gradle-dependencies-sorter plugin `0.9`.

0.19.6
------
Expand Down
4 changes: 2 additions & 2 deletions config/bin/sort-dependencies
Git LFS file not shown
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ okhttp = "5.0.0-alpha.12"
okio = "3.9.1"
retrofit = "2.11.0"
slack-lint = "0.8.1"
sortDependencies = "0.7"
sortDependencies = "0.9"
spotless = "7.0.0.BETA2"
sqldelight = "2.0.2"
versionsPlugin = "0.51.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ plugins {
}

dependencies {
lintChecks(libs.gradleLints)
implementation(libs.guava)

compileOnly(gradleApi())
Expand All @@ -30,4 +29,6 @@ dependencies {
testImplementation(libs.agp)
testImplementation(libs.junit)
testImplementation(libs.truth)

lintChecks(libs.gradleLints)
}
4 changes: 2 additions & 2 deletions platforms/gradle/foundry-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ dependencies.constraints {
}

dependencies {
lintChecks(libs.gradleLints)

api(platform(libs.okhttp.bom))
api(libs.okhttp)
// Better I/O
Expand Down Expand Up @@ -129,4 +127,6 @@ dependencies {
testImplementation(libs.junit)
testImplementation(libs.okio.fakefilesystem)
testImplementation(libs.truth)

lintChecks(libs.gradleLints)
}
52 changes: 27 additions & 25 deletions platforms/intellij/skate/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -118,39 +118,41 @@ configurations
.configureEach { attributes { attribute(KotlinPlatformType.attribute, KotlinPlatformType.jvm) } }

dependencies {
lintChecks(libs.composeLints)

compileOnly(libs.coroutines.core.ij)
implementation(projects.platforms.intellij.compose, exclusions)
implementation(projects.tools.tracing, exclusions)

implementation(libs.bugsnag)
implementation(libs.okio)
implementation(libs.kaml)
implementation(libs.kotlinx.serialization.core)
implementation(libs.okhttp)
implementation(libs.okhttp.loggingInterceptor)
implementation(projects.platforms.intellij.compose, exclusions)
implementation(projects.tools.tracing, exclusions)
implementation(libs.okio)

intellijPlatform {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this block removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below :). Looks like it's a bug

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// https://plugins.jetbrains.com/docs/intellij/android-studio.html#open-source-plugins-for-android-studio
// https://plugins.jetbrains.com/docs/intellij/android-studio-releases-list.html
// https://plugins.jetbrains.com/plugin/22989-android/versions/stable
plugin("org.jetbrains.android:242.21829.142")
bundledPlugins(
"com.intellij.java",
"org.intellij.plugins.markdown",
"org.jetbrains.plugins.terminal",
"org.jetbrains.kotlin",
)

pluginVerifier()
zipSigner()
instrumentationTools()

testFramework(TestFrameworkType.Platform)
testFramework(TestFrameworkType.Bundled)
}
Comment on lines -134 to -152
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp it broke all of this

compileOnly(libs.coroutines.core.ij)

testImplementation(libs.junit)
testImplementation(libs.truth)

lintChecks(libs.composeLints)
}

// Can't nest this inside of dependencies {} because otherwise the dependency sorter will remove it
dependencies.intellijPlatform {
// https://plugins.jetbrains.com/docs/intellij/android-studio.html#open-source-plugins-for-android-studio
// https://plugins.jetbrains.com/docs/intellij/android-studio-releases-list.html
// https://plugins.jetbrains.com/plugin/22989-android/versions/stable
plugin("org.jetbrains.android:242.21829.142")
bundledPlugins(
"com.intellij.java",
"org.intellij.plugins.markdown",
"org.jetbrains.plugins.terminal",
"org.jetbrains.kotlin",
)

pluginVerifier()
zipSigner()
instrumentationTools()

testFramework(TestFrameworkType.Platform)
testFramework(TestFrameworkType.Bundled)
}
4 changes: 2 additions & 2 deletions tools/cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ if (System.getenv("CI") != null) {
}

dependencies {
ksp(libs.autoService.ksp)

api(libs.clikt)

implementation(libs.autoService.annotations)
Expand All @@ -63,4 +61,6 @@ dependencies {

testImplementation(libs.junit)
testImplementation(libs.truth)

ksp(libs.autoService.ksp)
}