add inside/outside hot path benchmarks #261
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests will be a bit relative, but can be used to compare the
results before and after a PR. We can also verify that no allocations
are introduced on the hot path, perhaps in a GitHub actions check.
Because Interface.outside is not an interface, we have to actually
create a udp socket to write outgoing packets to in BenchmarkInside, so
the results look slower as they involve the kernel write path while
BenchmarkOutside is fully contained.
But we could use this benchmark to compare the results before and after
changing Interface.outside to an interface, as an example.