Guard e2e tun and udp channels on close #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
force-pushed
the
e2e-panic-test
branch
5 times, most recently
from
1cebf5d
to
c3ae7c3
Compare
nbrownus
changed the title
brad-defined
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of throwing a panic in a write after close in e2e tests, return an error or fail silently.
In the beginning there was a desire to tightly control packet flow in the e2e tests but as more complicated test cases arose that desire became very difficult to maintain. This led to tests with more automated packet shuffling than originally intended.
As a result some complicated tests can get into a situation where instances had just received a packet when we determine the test complete and close the nebula instance. The instance processing the packet determines it doesn't have a tunnel and tries to send a
recv_erroron the now closed fake udp socket.