Don't lock across update()

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
slackhq · Jul 24, 2024 · 301e0b7 · 301e0b7
1 parent 81cffeb
commit 301e0b7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/go/vt/vtgateproxy/discovery.go b/go/vt/vtgateproxy/discovery.go
@@ -211,14 +211,16 @@ func (b *JSONGateResolverBuilder) start() error {
  parseCount.Add("changed", 1)
 
  b.mu.RLock()
+ resolvers := b.resolvers
+ b.mu.RUnlock()
+
  // notify all the resolvers that the targets changed
- for _, r := range b.resolvers {
+ for _, r := range resolvers {
  err = b.update(r)
  if err != nil {
  log.Errorf("Failed to update resolver: %v", err)
  }
  }
- b.mu.RUnlock()
  }
  }()