Skip to content

Commit

Permalink
incident patch: disable the queryservice checks in rebuildkeyspacegra…
Browse files Browse the repository at this point in the history 
…ph call
  • Loading branch information
@maksimov
maksimov committed Jul 1, 2024
1 parent 404332b commit 35645ab
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions go/vt/topotools/rebuild_keyspace.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,16 @@ func RebuildKeyspaceLocked(ctx context.Context, log logutil.Logger, ts *topo.Ser
srvKeyspace, err := ts.GetSrvKeyspace(ctx, cell, keyspace)

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / End-to-End Test 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on ubuntu-latest 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtbackup_transform) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Local example using consul on ubuntu-latest 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / End-to-End Test (Race) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Local example using k8s on ubuntu-latest 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_singleton) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtorc_8.0) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_failover) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_failover) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_failover) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (tabletmanager_tablegc) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (13) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (13) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (13) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_readafterwrite) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_scheduler) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_scheduler) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_scheduler) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtctlbackup_sharded_clustertest_heavy) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revert) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_stress_suite) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (ers_prs_newfeatures_heavy) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (ers_prs_newfeatures_heavy) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (ers_prs_newfeatures_heavy) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revert) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_with_keyspaces_to_watch) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_with_keyspaces_to_watch) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vstream_with_keyspaces_to_watch) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vreplication_across_db_versions) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo_etcd) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo_etcd) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_topo_etcd) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (xb_recovery) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (26) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_reservedconn) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_reservedconn) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (22) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (22) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (22) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_schema) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_schema) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (schemadiff_vrepl) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (18) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (18) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (18) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_singleton) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_singleton) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_singleton) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_revertible) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_stress) mysql80 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vreplication_migrate) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vreplication_migrate) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vreplication_migrate) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (vtgate_vschema) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run endtoend tests on Cluster (onlineddl_vrepl_suite) mysql57 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 25 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 25 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 25 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 25 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run Upgrade Downgrade Test - Query Serving (Schema) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run Upgrade Downgrade Test - Reparent Old Vtctl 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run Upgrade Downgrade Test - Reparent Old VTTablet 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run Upgrade Downgrade Test - Query Serving (Queries) 

srvKeyspace declared and not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Docker Test Cluster 10 

srvKeyspace declared but not used

Check failure on line 81 in go/vt/topotools/rebuild_keyspace.go

View workflow job for this annotation

GitHub Actions / Run Upgrade Downgrade Test - Backups - Manual 

srvKeyspace declared and not used
switch {
case err == nil:
fmt.Println("Skipping");
/*
for _, partition := range srvKeyspace.GetPartitions() {
for _, shardTabletControl := range partition.GetShardTabletControls() {
if shardTabletControl.QueryServiceDisabled {
return fmt.Errorf("can't rebuild serving keyspace while a migration is on going. TabletControls is set for partition %v", partition)
}
}
}
*/
case topo.IsErrType(err, topo.NoNode):
// NOOP
default:
Expand Down

0 comments on commit 35645ab

Please sign in to comment.