Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: fixing issue with xtrabackup and long gtids (#16304) #510

Merged
merged 4 commits into from
Oct 10, 2024
Merged

backport: fixing issue with xtrabackup and long gtids (#16304) #510

merged 4 commits into from
Oct 10, 2024
+63 −27

Conversation

tanjinx
Copy link

@tanjinx tanjinx commented Sep 11, 2024

Description

backport upstream vitessio#16304

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@tanjinx tanjinx added upstream-backport An upstream backport v15 labels Sep 11, 2024
@tanjinx tanjinx requested a review from a team as a code owner September 11, 2024 18:15
@github-actions github-actions bot added this to the v15.0.5 milestone Sep 11, 2024
@rvrangel @tanjinx
fixing issue with xtrabackup and long gtids (vitessio#16304)
43aaed1 
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@timvaillancourt
Copy link
Member

@tanjinx can we backport this to slack-19.0 as well?

darenseagrave
darenseagrave previously approved these changes Sep 11, 2024
View reviewed changes
darenseagrave
darenseagrave previously approved these changes Sep 11, 2024
View reviewed changes
This was referenced Sep 11, 2024
Merged
Closed
@timvaillancourt
Copy link
Member

@tanjinx the failing CI can be fixed by:

goimports -local vitess.io/vitess -l -w ./go/vt/mysqlctl/xtrabackupengine_test.go

And committing the fixed file

@tanjinx
Copy link
Author

tanjinx commented Sep 11, 2024

goimports -local vitess.io/vitess -l -w ./go/vt/mysqlctl/xtrabackupengine_test.go

ah, til, thanks!

@timvaillancourt timvaillancourt merged commit 0f201a6 into slack-15.0 Oct 10, 2024
194 checks passed
@timvaillancourt timvaillancourt deleted the patch-16304 branch October 10, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@darenseagrave darenseagrave darenseagrave left review comments

@rvrangel rvrangel Awaiting requested review from rvrangel

Assignees
No one assigned
Labels
upstream-backport An upstream backport v15 v21-backport
Projects
None yet
Milestone
v15.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@tanjinx @timvaillancourt @darenseagrave @rvrangel