Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-19.0: use slackhq/vitess-addons@v0.19.6 #575

Open
wants to merge 10 commits into
base: slack-19.0
Choose a base branch
from

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Dec 17, 2024

Description

This PR updates slackhq/vitess-addons to the v0.19.5 tag TODO: cut v0.19.6 tag - currently using a pinned commit

Also the source-name for vtops problems was simplified to be vtorc-POOL-ENV vs. the longer/redundant vtorc-bedrock-POOL-ENV and a conditional to pass tablet alias to vtops-vtorc was added

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner December 17, 2024 15:49
@github-actions github-actions bot added this to the v19.0.7 milestone Dec 17, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
ejortegau
ejortegau previously approved these changes Dec 18, 2024

// TODO: remove this conditional and 'else' side after vtops-vtorc is used 100%.
if strings.HasSuffix(vtopsPath, "vtops-vtorc") {
vtopsExec.RaiseProblem(analysisEntry.AnalyzedInstanceAlias, "orc-dead-tablet")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made vtops-vtorc avoid some extra calls by passing an alias instead of hostname. This means we need this conditional during the rollout

@timvaillancourt timvaillancourt requested review from ejortegau and a team December 18, 2024 16:45
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-19.0: use slackhq/vitess-addons@v0.19.5 slack-19.0: use slackhq/vitess-addons@v0.19.6 Dec 18, 2024
go.mod Outdated
@@ -101,7 +101,7 @@ require (
github.com/kr/text v0.2.0
github.com/mitchellh/mapstructure v1.5.0
github.com/nsf/jsondiff v0.0.0-20210926074059-1e845ec5d249
github.com/slackhq/vitess-addons v0.19.4
github.com/slackhq/vitess-addons v0.19.6-0.20241218193729-2cb0c6fc208a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: cut a real tag before this is merged. This is a pinned commit

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants