Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't see how to get full error message #17

Closed
fredemmott opened this issue Jan 3, 2018 · 6 comments
Closed

Can't see how to get full error message #17

fredemmott opened this issue Jan 3, 2018 · 6 comments
Labels
external

Comments

@fredemmott
Copy link
Contributor

vscode is only showing me [Hack] Wrong type hint (17,42)

Nuclide and hh_client show me:

src/fbmarkdown/unparsed-blocks/Context.php:17:42,56: Wrong type hint (Typing[4110])
  src/fbmarkdown/unparsed-blocks/Context.php:17:26,38: This is an object of type Facebook\Markdown\UnparsedBlocks\BlockProducer
  src/fbmarkdown/unparsed-blocks/Context.php:27:5,15: It is incompatible with an object of type Facebook\Markdown\UnparsedBlocks\ListOfItems
@PranayAgarwal
Copy link
Contributor

Are you using the extension in LSP mode? If so, you'll need to create this issue against the hh_client source.

@fredemmott
Copy link
Contributor Author

This is exposed over LSP, but it might be an extension; nuclide pulls it up in LSP mode. That said, the vim8 LSP plugin also doesn’t make this info available

@fredemmott
Copy link
Contributor Author

This appears to be exposed as a non-standard relatedLocations field of the diagnostics.

@fredemmott
Copy link
Contributor Author

microsoft/language-server-protocol#260 is the proposal for this feature

@fredemmott
Copy link
Contributor Author

This functionality is now in the protocol, but hh_client's support is not compatible. FB task T29277163 to fix this.

@fredemmott
Copy link
Contributor Author

I have a hack-side fix for this (FB D8286533)

hhvm-bot pushed a commit to facebook/hhvm that referenced this issue Jun 5, 2018
@fredemmott @hhvm-bot
Support LSP-compliant relatedInformation field
59d1394 
Summary:
Include both the nuclide-specific `relatedLocations`, and the identical LSP-standard `relatedInformation`

fixes slackhq/vscode-hack#17

Reviewed By: pittsw, arxanas

Differential Revision: D8286533

fbshipit-source-id: 2b02928b875a44ee563e1999f9ba7a1f50a3bf2f
facebook-github-bot pushed a commit to facebook/flow that referenced this issue Jun 5, 2018
@fredemmott @facebook-github-bot
Support LSP-compliant relatedInformation field
30c21b9 
Summary:
Include both the nuclide-specific `relatedLocations`, and the identical LSP-standard `relatedInformation`

fixes slackhq/vscode-hack#17

Reviewed By: pittsw, arxanas

Differential Revision: D8286533

fbshipit-source-id: 2b02928b875a44ee563e1999f9ba7a1f50a3bf2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PranayAgarwal @fredemmott