Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Migrate to github actions #1009

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Conversation

jbellister-slac
Copy link
Collaborator

@jbellister-slac jbellister-slac commented Jul 6, 2023

Context

This PR removes the azure pipelines files, and replaces them with workflows for github actions. The intent is to keep the majority of the current functionality intact, but get to a state where maintenance and future updates are now much easier. There are some changes:

  • The test suite now runs against multiple versions of pyqt as was suggested in BLD: pin pyqt to 5.x #999
    5.12.3 is the one with designer support, 5.15.7 is the latest from conda-forge
  • Switched from conda to mamba to reduce solve time for testing and documentation building
  • Moved to trusted publishing for uploading to PyPI. This recently came out of beta and is now recommended as best practice (https://docs.pypi.org/trusted-publishers/)

The one workflow I haven't migrated over yet is the one that uploads to the pydm tag in anaconda. I'm not sure if we still want to maintain these separate tags with pydm available on conda-forge

https://anaconda.org/pydm-tag/pydm/files
https://anaconda.org/pydm-dev/pydm/files

Testing

All new files were tested on my fork.

This PR will kick off the new workflow for running tests.

The documentation job was tested here, though just uploading the built docs locally rather than pushing to gh-pages:
https://github.com/jbellister-slac/pydm/actions/runs/5449701997

The PyPI job was tested here against the test PyPI repository:
https://github.com/jbellister-slac/pydm/actions/runs/5470029942

@jbellister-slac jbellister-slac linked an issue Jul 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great!

@YektaY YektaY merged commit 9ad9cd8 into slaclab:master Jul 10, 2023
@jbellister-slac jbellister-slac deleted the actions branch July 10, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build and test pipelines
2 participants