-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add propertry for setting Qt Standard Icons in designer #1038
ENH: Add propertry for setting Qt Standard Icons in designer #1038
Conversation
Also fix minor spelling mistake in comments.
to test: -pydm examples/shell_command/shell_command.ui |
41402b4
to
9504e7c
Compare
Neat! Could this be extended to support the fontawesome stuff built into PyDM as well - |
can demo use of Qt's standard and Font Awesome icons with: pydm examples/icons/icons.ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a new display, worked exactly like I'd expect in both right hand window and basic settings editor in designer. Links for the valid icon names for both sets are good, example is helpful, and tests look good too. Thanks!
allow qt standard icons to be set in designer by exposing a custom property that sets the icon using python inside the property's setter.
this should provide a set of default icons cross-platform, since they ship with qt.