Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Archiver Timeplot address setters #1061

Merged
merged 6 commits into from
May 6, 2024

Conversation

zdomke
Copy link
Contributor

@zdomke zdomke commented Feb 21, 2024

Made changes to the address setters for ArchivePlotCurveItem and TimePlotCurveItem classes:

  1. Archive curve object now has an address setter that replaces the function setArchiveChannel. The setter calls the TimePlotCurveItem address setter, then sets the new address as the archive channel. This results in the live and archive channels always being tied to the same address.
  2. Both address setters now also check that the new address is different from the current address. If they're the same, the function returns.
  3. Changed the way the ArchivePlotCurveItem address setter replaces the address's protocol. Now the pydm utility is used.
  4. The TimePlotCurveItem address setter clears all live data tied to the previous channel. Similarly, the ArchivePlotCurveItem removes all archived data for the previous channel.

@zdomke zdomke marked this pull request as draft February 21, 2024 18:24
@YektaY YektaY marked this pull request as ready for review February 21, 2024 20:04
@YektaY YektaY changed the title Archiver Timeplot address setters ENH: Archiver Timeplot address setters Apr 12, 2024
zdomke added 2 commits May 2, 2024 09:15
Changing the implementation of the address property for the ArchiverCurveItem class to make it easier to read.
Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jbellister-slac jbellister-slac merged commit 22e04c6 into slaclab:master May 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants