FIX: in analong_indicator, explicitly cast to int for py310+ compat #1080
+28
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting at python 3.10, the rules for passing floats into python C extension modules like pyqt has gotten stricter.
See #951 (closes #951)
The analog indicator widgets have this issue, but they mask over it with try/except blocks to prevent the app from crashing.
This PR makes the widget render as intended by casting all variable inputs to int.
Some of these are guaranteed to always be ints, but some of them are floats. Rather than parse out which is which, I figured it was better to cover all of them.
Python 3.9 pre-PR:
Python 3.12 pre-PR:
Python 3.12 post-PR: