Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: pva image dim order option #1085

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Jun 26, 2024

add option for specifying how pydm should read pva image dimensions.

more context: #1082

@nstelter-slac nstelter-slac changed the title Dim ordering pva image dim order option Jun 26, 2024
@nstelter-slac nstelter-slac linked an issue Jun 26, 2024 that may be closed by this pull request
@nstelter-slac
Copy link
Collaborator Author

nstelter-slac commented Jun 26, 2024

This should keep current behavior when reading existing working pva images, but now also give the option to fix broken ones that have different dimension ordering in their sent-data.

To see how this patch fixes the address 'LAS:LHN:BAY3:CAM:NF2:IMAGE2:Pva:Image':

ssh -Yt <linux-username>@centos7.slac.stanford.edu
ssh -Yt psbuild-rhel7
source /cds/group/pcds/setup/epicsenv-cur.sh
source /cds/group/pcds/pyps/conda/pcds_conda
//clone pydm or have existing local pydm repo
//checkout this patch
cp ~tjohnson/junk/bay3_pva_test.ui ~/
cd pydm/pydm_launcher
PYTHONPATH=../ python main.py ~/bay3_pva_test.ui
open in designer
click on image view and go to properties
change new option 'dimensionOrder ' to 'widthFirst'

with dimensionOrder as widthFirst, you should get something similar to this:
Screenshot from 2024-06-24 14-09-38

@nstelter-slac nstelter-slac marked this pull request as draft June 26, 2024 02:11
@nstelter-slac nstelter-slac marked this pull request as ready for review June 26, 2024 02:14
@nstelter-slac nstelter-slac changed the title pva image dim order option ENH: pva image dim order option Jun 26, 2024
@jbellister-slac jbellister-slac merged commit 16e8bdb into slaclab:master Jul 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange Behavior with PyDMImageView and PVA Image
2 participants