-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Import/Export Plot Config #1101
Conversation
3594155
to
f18c392
Compare
f18c392
to
6d678d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple notes on adding doctrings
This one I think I need to be pointed to the corresponding Archive Viewer code to understand. The majority of these options are already stored in the underlying |
@zdomke may be able to answer this better than me, but yes - the goal of this is to be able to import and export whole plots with all configurations and settings. Analogous to how ArchivePlotCurveItem (and now FormulaCurveItem) has a to_dict function to store things like which color the curve is set to, its axis, and other settings, we also want to save things like plot title, whether Xgrid/ygrid is being shown, etc. Rather than storing this in a .ui file (if that’s what you’re suggesting) Zach and I opted to have an import/export file that stores a barebones dictionary of these settings for easy storage and we have functionality to read in such a dictionary and recreate the graph from the ground up. |
@jbellister-slac This information is stored in the For our needs we could move this to the Archive Viewer code, but we thought that it was generalized enough that other pydm users might get use of it too. Please let us know if you'd like us to move this to our side of things. |
Ok, thank you both for the context! I understand better now |
Opening the Archive Viewer, changing plot config, then saving it to a file requires that the plot config can be saved in a dictionary style data structure. This to_dict() function does that for us.