ENH: FormulaCurveItem Connection Status #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdomke
force-pushed
the
dev_formula_connection
branch
from
2c8eeab
to
feac408
Compare
zdomke
force-pushed
the
dev_formula_connection
branch
from
feac408
to
dff4a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds connection status checks to the FormulaCurveItem for both live and archive state. More details below:
FormulaCurveItemchanges:a. Add properties
connected,arch_connected,live_connectionsandarch_connectionsfor storing the status of the curve an all used curves. The curve is only connected if all used curves are connected.b. If the
FormulaCurveItemhas no live and no archive connection then the formula's evaluations are skipped.c. Set
plot_styledefault in__init__arguments definition.ArchivePlotCurveItemchange:a. Store the archiver channel's connection status in
arch_connected.