FIX: Check Validity of QAbstractTableModel Classes #1122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with adding basic tests to check the validity of 3
QAbstractTableModel
classes:BasePlotAxesModel
BasePlotCurvesModel
PyDMArchiverTimePlotCurvesModel
I fixed the issues that came up when the models were declared invalid. These fixes include:
flags()
, the models check the validity of the givenQModelIndex
data()
andsetData()
, returnsNone
instead of an emptyQVariant
object. This is done becauseQVariant
is not really needed in PyQt like it is in Qt. In some cases where it makes more sense, I replaced theQVariant
with empty strings.None
is an invalid QVariant, and that is what we should usepytest-qt
'sqtmodeltester
fixture that I used to test the models' validity checks thatNone
is being returned for invaliddata()
requests, notQVariant
Also added basic docstrings to
flags()
methods.