#350 code changes, docs will need changes, too, also test code #351
Conversation
|
✅ Build pydm 1.0.166 completed (commit bf0f07c7cb by @prjemian) |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 42.88% 42.88% +<.01%
==========================================
Files 69 69
Lines 6212 6198 -14
==========================================
- Hits 2664 2658 -6
+ Misses 3548 3540 -8
Continue to review full report at Codecov.
|
|
✅ Build pydm 1.0.167 completed (commit 7f57282a02 by @prjemian) |
|
✅ Build pydm 1.0.168 completed (commit 6960d1c810 by @prjemian) |
|
Pete, this seems great! One tricky thing to note: You can pass macros to python-based displays too, and those displays just get a dictionary that they can handle however they want. Because the JSON syntax allows you to differentiate between string values and numeric values ( I don't think that is a deal-breaker at all. It is a relatively easy fix for people writing displays to ensure they convert to a float or int or whatever before using macro arguments. We probably should have a note in the documentation explaining that if you use JSON syntax, you need to think about numeric vs string, and if you use the concise syntax, you can only ever get strings. |
|
It's a good thing to note. I was thinking about that as well. Without the JSON coding, all command line parameters are passed as strings. The other display managers handle the macros as strings. Are there cases for PyDM that require these values to be processed numerically? A note in the documentation should suffice. |
|
I think that we should give notice to developers and screens should expect to receive macros as strings and parse as they need it. Since it comes from the command line they should deal with that along the line and not expect the value to be on the type but ensure with a cast. |
Trying to use PyQt4 in qtlib raises so we can never hit the PyQt4 code paths.
MNT: remove remaining PyQt4 code
|
✅ Build pydm 1.0.179 completed (commit d48a0b77b8 by @mattgibbs) |
Before this is merged, will need docs (both in argparse setup and sphinx) and unit tests.
python ./main.py -m "AA=aa,BB=bb, CC=c{c}, DD=d[a<b}:_"