Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add PyDMDrawingPolygon #376

Merged
merged 2 commits into from
Jul 30, 2018
Merged

ENH: Add PyDMDrawingPolygon #376

merged 2 commits into from
Jul 30, 2018

Conversation

hhslepicka
Copy link
Contributor

Attn. @q563798715

This new widget has a property: numberOfPoints in which you can specify any value > 3.

screen shot 2018-07-26 at 5 38 50 pm

poly_wants_some_cracker

@AppVeyorBot
Copy link

Build pydm 1.0.252 failed (commit e01e290ae1 by @hhslepicka)

Copy link
Collaborator

@mattgibbs mattgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really simple, really nice. Way better than trying to draw out a hexagon in EDM!

@AppVeyorBot
Copy link

Build pydm 1.0.253 completed (commit 1328f13344 by @mattgibbs)

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #376 into master will increase coverage by 0.21%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage    42.6%   42.82%   +0.21%     
==========================================
  Files          69       69              
  Lines        6309     6335      +26     
==========================================
+ Hits         2688     2713      +25     
- Misses       3621     3622       +1
Impacted Files Coverage Δ
pydm/widgets/qtplugins.py 0% <0%> (ø) ⬆️
pydm/widgets/drawing.py 96.16% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec31fe0...a390ddc. Read the comment docs.

@hhslepicka
Copy link
Contributor Author

Thank you for the fix @mattgibbs . 👍

@hhslepicka hhslepicka merged commit 7208b28 into slaclab:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants