Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:add a new widget called ReadbackButton. #774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lvhuihui1988
Copy link
Contributor

…on in EDM that has two PV properties. One is Control PV and the other is Readback PV.
In edm, the button widget has two PV properties. One is Control PV, and the other is Readback PV. We can also set the color in Inconsistent property. When the two PVs' value are different, the inconsistent color will shown on the button.
Similarly, we need this functionality in PyDM GUIs. So I write a new widget called ReadbackButton. In this widget, I add a readback channel and inconsistentColor properties, as well as corresponding slot functions, relative to the PushButton widget.

@lvhuihui1988 lvhuihui1988 changed the title WIP:add a new widget called ReadbackButton. It is similar to the butt… WIP:add a new widget called ReadbackButton. Nov 22, 2021
@lvhuihui1988 lvhuihui1988 reopened this Nov 22, 2021
@lvhuihui1988 lvhuihui1988 reopened this Nov 22, 2021
@lvhuihui1988
Copy link
Contributor Author

In edm, the button widget has two PV properties. One is Control PV, and the other is Readback PV. We can also set the color in Inconsistent property. When the two PVs' value are different, the inconsistent color will shown on the button.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 272 lines in your changes missing coverage. Please review.

Project coverage is 57.43%. Comparing base (9ac9bd5) to head (97eff3e).
Report is 1229 commits behind head on master.

Files with missing lines Patch % Lines
pydm/widgets/readbackbutton.py 0.00% 270 Missing ⚠️
pydm/widgets/qtplugins.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   58.92%   57.43%   -1.49%     
==========================================
  Files          91       92       +1     
  Lines       10543    10815     +272     
==========================================
  Hits         6212     6212              
- Misses       4331     4603     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…on in EDM that has two PV properties. One is Control PV and the other is Readback PV.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants